fix: Use hashed request_id as cache key in shared RQ client reclaim_request#795
Open
fix: Use hashed request_id as cache key in shared RQ client reclaim_request#795
Conversation
…equest The reclaim_request method was using request.unique_key directly as the cache key, while all other methods use unique_key_to_request_id() to compute a hashed request_id. This inconsistency caused orphaned cache entries since cached requests were stored under a different key than what other methods would look up. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #795 +/- ##
==========================================
+ Coverage 85.46% 85.57% +0.11%
==========================================
Files 46 46
Lines 2697 2697
==========================================
+ Hits 2305 2308 +3
+ Misses 392 389 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApifyRequestQueueSharedClient.reclaim_request, the cache key was set torequest.unique_key(raw URL string) instead of the hashedrequest_id(viaunique_key_to_request_id)_cache_requestcall in the class uses the hashedrequest_id, creating an inconsistency that causes orphaned cache entriesrequest_idwould miss the reclaimed request, potentially causing re-fetches or incorrect processingTest plan
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com