Skip to content

fix: Fix PlaywrightCrawler unintentionally setting the global configuration#1747

Merged
Pijukatel merged 1 commit intomasterfrom
fix-pw--custom-configuration
Feb 13, 2026
Merged

fix: Fix PlaywrightCrawler unintentionally setting the global configuration#1747
Pijukatel merged 1 commit intomasterfrom
fix-pw--custom-configuration

Conversation

@Pijukatel
Copy link
Collaborator

Description

  • Remove unintentional side-effect: When a custom configuration was passed to the PlaywrightCrawler, it tried to set it in the global service_locator

Testing

  • Updated unit test

Checklist

  • CI passed

@Pijukatel Pijukatel added the adhoc Ad-hoc unplanned task added during the sprint. label Feb 13, 2026
@github-actions github-actions bot added this to the 134th sprint - Tooling team milestone Feb 13, 2026
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Feb 13, 2026
@Pijukatel Pijukatel requested a review from vdusek February 13, 2026 13:05
@Pijukatel Pijukatel assigned Mantisus and unassigned Mantisus Feb 13, 2026
@Pijukatel Pijukatel requested a review from Mantisus February 13, 2026 13:05
@Pijukatel Pijukatel marked this pull request as ready for review February 13, 2026 13:06
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.40%. Comparing base (568a7b1) to head (539cb33).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1747      +/-   ##
==========================================
- Coverage   92.41%   92.40%   -0.02%     
==========================================
  Files         156      156              
  Lines       10628    10624       -4     
==========================================
- Hits         9822     9817       -5     
- Misses        806      807       +1     
Flag Coverage Δ
unit 92.40% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@Mantisus Mantisus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pijukatel Pijukatel merged commit fa58438 into master Feb 13, 2026
32 checks passed
@Pijukatel Pijukatel deleted the fix-pw--custom-configuration branch February 13, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants