Skip to content

Conversation

@Vasuk12
Copy link
Contributor

@Vasuk12 Vasuk12 commented Jan 2, 2026

Implements support for the TensorFlow Erfc operation.
Changes:

  • Added ERFC function that converts Erfc using erfc(x) = 1 - erf(x)

  • Registered the op with @register_tf_op(tf_alias=["Erfc"])

Fixes #2622

@Vasuk12
Copy link
Contributor Author

Vasuk12 commented Jan 2, 2026

Hi, Lmk if I am missing something in this implementation :)

@TobyRoseman
Copy link
Collaborator

Please add a unit test.

Signed-off-by: Vasu <vasukhare88@gmail.com>
@Vasuk12
Copy link
Contributor Author

Vasuk12 commented Jan 3, 2026

Please add a unit test.

Added a unit test.

@TobyRoseman
Copy link
Collaborator

Thanks for adding a unit test.

I've kicked off a CI run for this change:
https://gitlab.com/coremltools1/coremltools/-/pipelines/2245613294

If that passes, I will merge this change.

@Vasuk12
Copy link
Contributor Author

Vasuk12 commented Jan 5, 2026

Thanks for adding a unit test.

I've kicked off a CI run for this change:

https://gitlab.com/coremltools1/coremltools/-/pipelines/2245613294

If that passes, I will merge this change.

Sounds good.

@TobyRoseman TobyRoseman merged commit cf439be into apple:main Jan 5, 2026
@TobyRoseman
Copy link
Collaborator

Thanks @Vasuk12

@Vasuk12
Copy link
Contributor Author

Vasuk12 commented Jan 5, 2026

Thanks @Vasuk12

Happy to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TF] Add support for Erfc op

2 participants