Support for differently-named settings files or structures#13
Open
skoczen wants to merge 3 commits intoappliedsec:masterfrom
Open
Support for differently-named settings files or structures#13skoczen wants to merge 3 commits intoappliedsec:masterfrom
skoczen wants to merge 3 commits intoappliedsec:masterfrom
Conversation
CURRENT_DIR = os.path.dirname(os.path.abspath(__file__)) class SiteAndPathUtils(object):
|
I'd like to see this change get merged in, as modular settings is a very common pattern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use
project/settings/dev.py/project/settings/production.pyor something similar in a lot of projects.This PR provides a way to explicitly set the project root path, instead of only the magic
replace('.settings', '')method.Thanks for a great project!
If this looks good and gets merged, a quick version bump and pypi release would be awesome, so I can pull our projects off my fork and back on to trunk.
Thanks!