Add requests dependency to hatch-build env
#253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After changes in Hatch 1.16, it seems that the build hook script is sometimes ran within the `hatch-build` environment, rather than in the `build` environment it is declared for. As such, the `requests` dependency for the build hook must be declared for this environment, as well as for the script itself.
Contributor
Author
|
Again, merging to be able to run the test setups' CI against it, but do review. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #252 -- this should actually fix the failing test setups' CI. The changes in #252 fixed the issue for me when building the package locally, but they did not fix it when the test setups build the package. I'm unsure what the difference is.
After changes in Hatch 1.16, it seems that the build hook script is sometimes ran within the
hatch-buildenvironment, rather than in thebuildenvironment it is declared for. As such, therequestsdependency for the build hook must be declared for this environment, as well as for the script itself.