-
-
Notifications
You must be signed in to change notification settings - Fork 200
some improvements to "Extensions Hooks" documentation #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe documentation file docs/Developer-Guide_Extensions-Hooks.md was edited to state the Hooks list is non-exhaustive, add a concrete grep command to enumerate available hooks from the build/ directory, remove the previous autogenerated-from-arbian/build assertion, update the opt-out link text to point to a specific how-to page, and revise the introductory note about hook ordering to reflect the new non-exhaustive guidance. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5c60295 to
3182039
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/Developer-Guide_Extensions-Hooks.md (1)
5-5: Consider minor wording improvement.The phrase "but the list is not complete" could be more concisely expressed as "but the list is incomplete" for improved clarity and brevity.
This is purely optional but aligns with the static analysis suggestion.
-Hooks listed below appear in the order in which they are called, but the list is not complete. +Hooks listed below appear in the order in which they are called, but the list is incomplete.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/Developer-Guide_Extensions-Hooks.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/Developer-Guide_Extensions-Hooks.md
[style] ~5-~5: Consider using “incomplete” to avoid wordiness.
Context: ... which they are called, but the list is not complete. - Running 'grep -h call_extension_meth...
(NOT_ABLE_PREMIUM)
|
This could also be baked into command ./compile.sh show-extensions ? |
Never heard of it. I guess the command is undocumented? |
please check the commits