Skip to content

Conversation

@leggewie
Copy link
Collaborator

please check the commits

@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review labels Dec 15, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Walkthrough

The documentation file docs/Developer-Guide_Extensions-Hooks.md was edited to state the Hooks list is non-exhaustive, add a concrete grep command to enumerate available hooks from the build/ directory, remove the previous autogenerated-from-arbian/build assertion, update the opt-out link text to point to a specific how-to page, and revise the introductory note about hook ordering to reflect the new non-exhaustive guidance.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single documentation file changed; no code or behavioral changes
  • Minor text updates, link change, and addition of a command example
  • No complex logic to validate

Possibly related PRs

Suggested reviewers

  • igorpecovnik
  • EvilOlaf

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description is minimal but related to the changeset. It requests review of commits without being completely off-topic or unrelated to the documentation changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title refers to improvements to documentation about Extensions Hooks, which directly matches the file modified (docs/Developer-Guide_Extensions-Hooks.md) and the changes made to that documentation.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@leggewie leggewie force-pushed the main branch 2 times, most recently from 5c60295 to 3182039 Compare December 15, 2025 10:02
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
docs/Developer-Guide_Extensions-Hooks.md (1)

5-5: Consider minor wording improvement.

The phrase "but the list is not complete" could be more concisely expressed as "but the list is incomplete" for improved clarity and brevity.

This is purely optional but aligns with the static analysis suggestion.

-Hooks listed below appear in the order in which they are called, but the list is not complete.
+Hooks listed below appear in the order in which they are called, but the list is incomplete.
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5c60295 and 3182039.

📒 Files selected for processing (1)
  • docs/Developer-Guide_Extensions-Hooks.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/Developer-Guide_Extensions-Hooks.md

[style] ~5-~5: Consider using “incomplete” to avoid wordiness.
Context: ... which they are called, but the list is not complete. - Running 'grep -h call_extension_meth...

(NOT_ABLE_PREMIUM)

@leggewie leggewie changed the title some improvements to "Hooks Extensions" documentation some improvements to "Extensions Hooks" documentation Dec 15, 2025
@igorpecovnik
Copy link
Member

igorpecovnik commented Dec 15, 2025

This could also be baked into command

./compile.sh show-extensions ?

@leggewie
Copy link
Collaborator Author

This could also be baked into command

./compile.sh show-extensions ?

Never heard of it. I guess the command is undocumented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs review Seeking for review size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants