Open
Conversation
UncleGrumpy
requested changes
Mar 4, 2024
Collaborator
There was a problem hiding this comment.
Sorry, it looks like this was missed for a while. I just had a few comments, if you want to take care of those. We don't have any CI checks in place yet, but we should have you sign off on the commit. (Hint: git commit --amend --signoff after you make the changes)
| @@ -0,0 +1,7 @@ | |||
| {erl_opts, [debug_info]}. | |||
| {deps, [ | |||
| {atomvm_lib, {git, "https://github.com/atomvm/atomvm_lib.git", {branch, "master"}}} | |||
Collaborator
There was a problem hiding this comment.
This dependency shouldn't be necessary for this demo.
| @@ -0,0 +1,4 @@ | |||
| [{<<"atomvm_lib">>, | |||
|
|
||
| send_messages() -> | ||
| ReceiverPid = whereis(receiver), | ||
| ReceiverPid ! on, |
Collaborator
There was a problem hiding this comment.
receiver ! on, works now if you want to make this a little cleaner, but that is up to you.
| ReceiverPid = whereis(receiver), | ||
| ReceiverPid ! on, | ||
| timer:sleep(2000), | ||
| ReceiverPid ! off, |
Collaborator
|
We have added the "reuse" workflow, so if you could rebase your changes, when you sign off on the commit, we can run that check to make sure that others can freely use this demo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a demo that blinks the LED by passing messages between processes.