Open
Conversation
added 14 commits
July 18, 2019 12:07
Owner
Author
|
Maybe It wold be good to use |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately this PR includes python3 changes as well as the mypy changes, I think up to
a58386c
The version upgrade was necessitated for convenient mypy type annotations
A couple things:
x: int = 3pydanticor something similar (add py.typed marker file for PEP-561 support pydantic/pydantic#391) because we can hide the constructor behind assertions that enforce other guarantees about the type (like extant_file)