chore(batch): undeprecate useOptimalInstanceClasses property #36353
+45
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #36291.
Reason for this change
The
useOptimalInstanceClassesproperty was deprecated in v2.220 in favor ofdefaultInstanceClasses, but there is no way to exclude theoptimalinstance type usingdefaultInstanceClassesalone. Users who want to specify only custom instance types (e.g., R4 only) withoutoptimalbeing automatically added have no non-deprecated path forward.Setting
defaultInstanceClasses: [](empty array) does not preventoptimalfrom being added because the current logic treats an empty array the same asundefined.Description of changes
@deprecatedannotation fromuseOptimalInstanceClassespropertyuseOptimalInstanceClasses: falseto excludeoptimalAlternatives considered
Three options were discussed in #36291:
useOptimalInstanceClassesas a non-deprecated propertydefaultInstanceClasses: []as "exclude all defaults" - Would introduces implicit behaviorOption 1 was chosen because:
useOptimalInstanceClassesprovides explicit, clear control thatdefaultInstanceClassescannot fully replaceDescribe any new or updated permissions being added
N/A
Description of how you validated changes
Existing tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license