feat(bedrock-agentcore-alpha): make physical name properties optional for AgentCore resources #36354
Conversation
github-actions
bot
added
feature-request
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Features must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
|
||||||||||||||
|
||||||||||||||
github-actions
bot
added
the
effort/medium
|
Exemption Request: This change only makes physical name properties optional with auto-generation fallback - no new functionality or CloudFormation template changes that would require integration test snapshots. |
aws-cdk-automation
added
pr-linter/exemption-requested
badmintoncryer
left a comment
badmintoncryer
left a comment
There was a problem hiding this comment.
Thank you for your contribution! I've added a minor comment.
| expect(memory.kmsKey?.keyArn).toBeDefined(); | ||
| }); | ||
| }); | ||
| // Tests for optional physical names (issue #36341) |
There was a problem hiding this comment.
I think this comment is not essential.
| // Tests for optional physical names (issue #36341) |
Could you please remove this line from gateway/runtime/browser.test.ts?
There was a problem hiding this comment.
This comment was included in all AgentCore resource tests...🤦
Thank you. I've deleted it.
There was a problem hiding this comment.
I've not realized that.. Sorry if you're asked by the maintainer to restore the comments.
There was a problem hiding this comment.
Your point is correct :)
These are all unnecessary comments that I added in this PR, so I should have deleted them.
aws-cdk-automation
removed
the
pr/needs-community-review
aws-cdk-automation
added
the
pr/needs-maintainer-review
3 participants
Issue # (if applicable)
Closes #36341.
Reason for this change
Improve AWS Bedrock AgentCore constructs by making physical name properties optional, following CDK best practices where names are auto-generated when not specified for better usability and to avoid naming conflicts.
Description of changes
Made physical name properties optional for all AWS Bedrock AgentCore constructs:
Names.uniqueResourceName()when names are omittedDescribe any new or updated permissions being added
None.
Description of how you validated changes
Added unit tests for auto-generation functionality for all constructs
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license