chore(rosetta): upgrade jsii-rosetta and add batch flag #36389
+16
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade jsii-rosetta from ~5.9.15 to ~5.9.20 to leverage performance improvements. Add --batch 1000 flag to rosetta extract commands to improve processing efficiency.
Contributor
|
||||||||||||||
Contributor
|
||||||||||||||
aws-cdk-automation
added
the
pr/needs-maintainer-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A
Reason for this change
This change upgrades jsii-rosetta to leverage recent performance improvements and adds batch processing to improve the efficiency of code sample extraction during the build process.
Description of changes
This PR makes two related changes to improve the rosetta extraction process. First, it upgrades jsii-rosetta from version ~5.9.15 to ~5.9.20 to take advantage of the latest performance improvements and bug fixes in the rosetta tooling. Second, it adds the
--batch 1000flag to both rosetta extract commands in the run-rosetta.sh script, which enables batch processing of code samples and should significantly improve extraction performance for large codebases.Describe any new or updated permissions being added
No new or updated IAM permissions are needed.
Description of how you validated changes
The changes have been tested locally to ensure the rosetta extraction process completes successfully with the new version and batch flag.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license