Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Dec 15, 2025

Issue # (if applicable)

N/A

Reason for this change

The AWS CDK repository currently uses Node.js 18 in the PR build workflow, but Node.js 18 has reached end-of-life. Node.js 20 is now the recommended LTS version and should be used for CI/CD pipelines to ensure security updates and compatibility with modern tooling. See our deprecation announcement.

Description of changes

This change updates the PR build workflows to use Node.js 20 instead of Node.js 18, aligning with current best practices and ensuring the build environment stays up-to-date with supported Node.js versions.

Describe any new or updated permissions being added

No new or updated permissions are required for this change.

Description of how you validated changes

The change only affects the Node.js version used in GitHub Actions workflows. The workflow configuration has been updated and will be validated when the PR build runs.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 15, 2025 11:15
@github-actions github-actions bot added the p2 label Dec 15, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 15, 2025
@mrgrain mrgrain force-pushed the mrgrain/chore/node-20 branch from d054dd9 to 25c70d0 Compare December 15, 2025 11:17
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

TestsPassed ❌️SkippedFailed
Security Guardian Results
TestResult
No test annotations available

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

TestsPassed ❌️SkippedFailed
Security Guardian Results with resolved templates
TestResult
No test annotations available

@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Dec 15, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 15, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 15, 2025
@mrgrain mrgrain removed the pr/do-not-merge This PR should not be merged at this time. label Dec 15, 2025
@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2025

Merge Queue Status

✅ The pull request has been merged at f366abd

This pull request spent 30 minutes 39 seconds in the queue, including 30 minutes 30 seconds running CI.
The checks were run in-place.

Required conditions to merge

@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 244c02d into main Dec 15, 2025
21 of 22 checks passed
@mergify mergify bot deleted the mrgrain/chore/node-20 branch December 15, 2025 20:04
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants