Test Consolidation and Module Restructuring #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Analyzed all 30 test classes (459 test methods) - Classified tests: 4 unit, 20 integration, 2 performance, 4 stress - Identified cross-module dependencies - Documented Dropwizard usage in core module - Proposed restructuring: perf-test module + integration-test separation - No code changes, inventory only
Changes: - Move RE2MetricsConfig.java to libre2-core/dropwizard package - Move 3 test files (JmxIntegrationTest, MetricsEndToEndTest, RE2MetricsConfigTest) to core - Add metrics-jmx dependency to libre2-core (provided scope, optional) - Remove libre2-dropwizard module from parent POM - Delete libre2-dropwizard directory Result: All 459 tests passing, BUILD SUCCESS Multi-module structure retained for future module additions
Changes: - Create new perf-test Maven module - Move 2 performance tests to perf-test/performance package - BulkMatchingPerformanceTest - CachePerformanceTest - Move 4 stress tests to perf-test/stress package - StressTest - ConcurrencyTest - ConcurrentCleanupTest - EvictionWhileInUseTest - Configure libre2-core to build test-jar for sharing test utilities - Add test-jar dependency in perf-test for TestUtils access - Update package declarations and add necessary imports Result: All 459 tests passing (431 in libre2-core, 28 in perf-test) Performance/stress tests now separated for independent CI execution
Changes: - Remove references to deleted libre2-dropwizard module - Add perf-test module paths - Workflow now triggers on changes to: - libre2-core/src/** (was already there) - perf-test/src/** (NEW) - pom.xml files for both modules
The workflow was still checking for libre2-dropwizard/target/*.jar which no longer exists after consolidation into libre2-core. This was causing the build to fail at the 'Verify JAR contents' step.
Problem: libre2-core-*.jar now matches TWO jars: - libre2-core-1.0.0.jar (main) - libre2-core-1.0.0-tests.jar (test-jar for sharing test utils) The unzip commands were failing because the glob expanded to multiple files. Solution: Use libre2-core-1.0.0.jar explicitly in all unzip commands. Keep wildcard only in ls to show both JARs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Testing CI with restructured modules and test organization.
Changes
Test Status
Next Steps