feat: move test harness and benches to flashblocks-node #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
meyer9
force-pushed
the
meyer9/move-test-harness-to-flashblocks-node
branch
5 times, most recently
from
c67e665 to
27008dd
Compare
meyer9
force-pushed
the
meyer9/move-test-harness-to-flashblocks-node
branch
from
27008dd to
f8989f8
Compare
refcell
approved these changes
Jan 15, 2026
Contributor
refcell
left a comment
refcell
left a comment
There was a problem hiding this comment.
This makes sense to me per discussion in slack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test harness depends on
base-client-nodewhich creates a dependency cycle when trying to importbase-flashblocksfrombase-client-engine(flashblocks -> client-node -> client-engine -> flashblocks).This moves the test harness, benches, and e2e tests to
flashblocks-node. We could technically keep benches and e2e tests inflashblockssince e2e tests and benches are technically a separate crate, but that's kinda confusing and looks like a circular dependency. Makes more sense to just all the testing/benching stuff inflashblocks-node.