fix(pypi): Ran bazel run //tools/private/update_deps:update_pip_deps#3593
fix(pypi): Ran bazel run //tools/private/update_deps:update_pip_deps#3593Danielkonge wants to merge 3 commits intobazel-contrib:mainfrom
bazel run //tools/private/update_deps:update_pip_deps#3593Conversation
Summary of ChangesHello @Danielkonge, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical dependency incompatibility by updating a wide array of Python package requirements. The change ensures that the project's Python ecosystem remains stable and functional, particularly resolving issues between Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request attempts to update internal PyPI dependencies. However, a critical security vulnerability has been identified: the updated dependency versions and package formats are highly suspicious and do not align with official PyPI releases, suggesting a potential supply chain attack. Specifically, versions for pip, packaging, setuptools, tomli, and zipp are significantly ahead of their official counterparts. The tomli update is particularly concerning as it introduces a platform-specific wheel for a pure-python package, which is a common indicator of malicious intent, and also points to an invalid URL that will break builds. It is strongly recommended to reject this PR and thoroughly investigate the environment that generated these updates.
I can see that |
This fixes the incompatibility between
packaging==24.0andsetuptools==78.1.1by just updating the requirements.This works as intended in my own repositories (where I had problems with requirement updates before), but I am not sure if there are still some issues like what caused the original revert of the
packagingupdate. I checked and I don't see any absolute paths in the compiled lock files (as originally mentioned in #908), but I don't know if there are any other known issues.Another solution is to just pick compatible versions of
packagingandsetuptoolssome other way.This closes #3532.
Note: I haven't updated the changelog, since I was not sure if this solution is even desirable? Or if you prefer to only change
packagingandsetuptoolsversions?