chore: add a script to easily checkout prs#3600
chore: add a script to easily checkout prs#3600rickeylev wants to merge 2 commits intobazel-contrib:mainfrom
Conversation
Summary of ChangesHello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new utility script designed to significantly simplify the workflow for interacting with GitHub Pull Requests. It addresses common complexities, particularly in 'triangle' development models, by automating the process of checking out, pulling updates from, and pushing changes to PR branches. The script aims to enhance developer efficiency by providing a more intuitive command-line interface for PR management. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a useful git-pr script to streamline the process of checking out, pulling, and pushing changes for GitHub pull requests, especially in a 'triangle workflow' setup. However, the script contains several instances of unquoted variables in shell commands, specifically in git push and git pull operations, which can lead to word splitting and argument injection. This practice is insecure and should be remediated by consistently using double quotes around variables. Additionally, there is a critical bug in handling the base remote for certain PRs, and improvements are needed for error handling consistency and user experience.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
I use the gh CLI and you just need to do gh pr checkout to checkout a particular PR. |
|
I've had endless trouble trying to use plain |
This adds a script I've had for awhile to make it easier to grab PRs and work on them.
It makes grabbing and editing a user's PR much easier, especially with some aliases
setup:
While things like
gh pr checkoutexist, it doesn't well handle the "triangle"workflow and some other edge cases.