Allow PHP 8 #89
Open
Allow PHP 8 #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't use symfony regularly, but I guess these changes would break on earlier Symfony versions, right? |
Author
|
Unfortunately yes, these are tweaks done to make the bundle run in Symfony 5.x. |
This reverts commit db62e23.
…d "void" as a native return type declaration in the future. Do the same in this child class now to avoid errors or add an explicit @return annotation to suppress this message.
…)" might add "void" as a native return type declaration in the future. Do the same in this child class now to avoid errors or add an explicit @return annotation to suppress this message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to composer.json to allow PHP 8.
Thanks in advance!
Kind regards,
David
P.S. Apologies for closing off #88 earlier, but I forked it in the wrong place for it to remain a "long-living fork" for us :-)