Add LARS to str2optimizer32bit dictionary#1855
Open
Mr-Neutr0n wants to merge 1 commit intobitsandbytes-foundation:mainfrom
Open
Add LARS to str2optimizer32bit dictionary#1855Mr-Neutr0n wants to merge 1 commit intobitsandbytes-foundation:mainfrom
Mr-Neutr0n wants to merge 1 commit intobitsandbytes-foundation:mainfrom
Conversation
LARS optimizer was missing from str2optimizer32bit, causing KeyError when using LARS32bit optimizer. LARS uses momentum-based kernels since it's essentially SGD with momentum plus layerwise adaptive learning rates. Fixes bitsandbytes-foundation#1810
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
str2optimizer32bitdictionary mapping to momentum kernelsblock_wise=False, so no changes needed tostr2optimizer8bit_blockwiseRelated Issue
Fixes #1810
Test plan