feat(core, prompts): add DatePrompt for date input with customizable formats by dreyfus92 · Pull Request #448 · bombshell-dev/clack

dreyfus92 · 2026-01-31T20:41:09Z

Implements a date prompt that enforces a structured date format and supports the most common variants: YYYY/MM/DD, MM/DD/YYYY, and DD/MM/YYYY.

related: #447

…formats

changeset-bot · 2026-01-31T20:41:13Z

🦋 Changeset detected

Latest commit: fc7301f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clack/prompts	Minor
@clack/core	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2026-01-31T20:41:44Z

@example/basic

@example/changesets

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/core@448

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/prompts@448

commit: fc7301f

natemoo-re

Looking great so far! Left a few comments—happy to clarify if anything doesn't make sense.

.changeset/tangy-mirrors-hug.md

packages/core/src/prompts/date.ts

packages/prompts/src/date.ts

davidwarrington · 2026-02-02T22:44:10Z

I'm really liking this so far, but I have a few thoughts

Should the input support min and max dates?
When you interact with the input for the first time, the other segments default to a value of 00. Since month and date can't be 00 I'm not sure if this makes sense. A benefit of the current implementation is it requires the user to select their own month and date still, rather than being able to accidentally submit 01 before they've had an opportunity to change it, but if that's the intention, I'd expect the segments to remain __ until updated manually.
The expected input format isn't obvious. Given __/__/____ how do I know which segment represents month and which represents date?
The input formats use / as a separator, but the rendered output uses -. This can be ignored if the input switches to use Date though.

43081j · 2026-02-03T08:57:34Z

it'd be good to render dd / mm / yyyy for example and, as you fill it in, it clears

so it goes like this:

dd / mm / yyyy (all of these are grey/subtle)
10 / mm / yyyy (10 is white, mm/yyyy are grey still)

etc

dreyfus92 · 2026-02-04T06:16:56Z

Thanks everyone for your feedback so far 😄

dreyfus92 · 2026-02-04T06:34:45Z

i've tested this locally and i don't get any errors, which is weird.

I think the CI is failling due to the internal value i set withnew Date(iso) where iso is "2025-01-15". in js that is UTC midnight. so the ui uses local getFullYear() / getMonth() / getDate() to show the date.

so:

CI (UTC): 2025-01-15T00:00:00Z → local day = 15.
my machine: same instant → local day = 14.

also maybe snapshots were created on my local env (14), while CI (UTC) produced 15, so the snapshot comparison failed.

i might need to think about fixing this in the upcoming days.

natemoo-re · 2026-02-12T01:59:59Z

packages/core/src/prompts/date.ts

+	}
+
+	get cursor() {
+		// Convert segment cursor to absolute position for backward compatibility


Is backward compatibility needed?

natemoo-re · 2026-02-12T02:00:28Z

packages/core/src/prompts/date.ts

+		return start + this.#cursor.positionInSegment;
+	}
+
+	/** Get current segment cursor position */


Suggested change

/** Get current segment cursor position */

natemoo-re · 2026-02-12T02:01:41Z

packages/core/src/prompts/date.ts

+	#segmentValues: DateParts;
+	#minDate: Date | undefined;
+	#maxDate: Date | undefined;
+	/** Segment-based cursor: { segmentIndex, positionInSegment } */


Suggested change

/** Segment-based cursor: { segmentIndex, positionInSegment } */

natemoo-re · 2026-02-12T02:02:04Z

packages/core/src/prompts/date.ts

+	#minDate: Date | undefined;
+	#maxDate: Date | undefined;
+	/** Segment-based cursor: { segmentIndex, positionInSegment } */
+	#cursor: { segmentIndex: number; positionInSegment: number } = {


Type can be trivially inferred here?

natemoo-re · 2026-02-12T02:02:19Z

packages/core/src/prompts/date.ts

+		// Initialize cursor to first segment, position 0
+		this.#cursor = { segmentIndex: 0, positionInSegment: 0 };


This is already the default value

natemoo-re · 2026-02-12T02:04:58Z

packages/core/src/prompts/date.ts

+			0,
+			Math.min(seg.len - 1, this.#cursor.positionInSegment)
+		);
+		return { segment: seg, index };


Definite nit, but we can name the variable segment to avoid assignment here

natemoo-re · 2026-02-12T02:12:56Z

packages/core/src/prompts/date.ts

+		return { segment: seg, index };
+	}
+
+	#onCursor(key?: string) {


This is a lot of direct manipulation in an event handler—would prefer if we could refactor to call out to methods that adjust state like #incrementCurrentSegment, #decrementCurrentSegment, #moveCursorNext, #moveCursorPrevious

natemoo-re · 2026-02-12T02:21:40Z

packages/core/src/prompts/date.ts

+				newNum = key === 'up' ? bounds.min : bounds.max;
+			} else {
+				const delta = key === 'up' ? 1 : -1;
+				newNum = Math.max(bounds.min, Math.min(bounds.max, num + delta));


Also a nit, but we're doing Math.max(min, Math.min(max, num)) enough that we should have a generic util for clamp(min, num, max)

natemoo-re · 2026-02-12T02:23:20Z

packages/core/src/prompts/date.ts

+	#refreshFromSegmentValues() {
+		const display = this.#config.format(this.#segmentValues);
+		this._setUserInput(display);
+		this._setValue(segmentValuesToDate(this.#segmentValues) ?? undefined);
+	}


Would it be possible to have userInput and value be fully derived so that we don't need to imperatively call #refereshFromSegmentValues() manually?

natemoo-re · 2026-02-12T02:27:00Z

packages/core/src/prompts/date.ts

+}
+
+function daysInMonth(year: number, month: number): number {
+	return new Date(year || 2000, month || 1, 0).getDate();


2000 was a leap year, so maybe not the best default?

feat(core, prompts): add DatePrompt for date input with customizable …

be9d7fc

…formats

chore: add changeset

24c385a

dreyfus92 requested review from 43081j and natemoo-re January 31, 2026 21:04

natemoo-re reviewed Feb 1, 2026

View reviewed changes

dreyfus92 added 3 commits February 3, 2026 19:42

refactor: DatePrompt based on @natemoo-re's suggestions

eb1c844

chore: update date prompt snapshots

ad33564

feat(date): add min/max, segment hints, keep blank segments on up/down

b9206d8

dreyfus92 requested a review from natemoo-re February 4, 2026 06:16

dreyfus92 added 3 commits February 5, 2026 19:45

fix(date): use local date for display so CI snapshots match

9f53979

refactor(date): DRY format rendering and extract helpers

df8a9e1

revert: pnpm's version

fc7301f

natemoo-re reviewed Feb 12, 2026

View reviewed changes

		// Initialize cursor to first segment, position 0
		this.#cursor = { segmentIndex: 0, positionInSegment: 0 };

Conversation

dreyfus92 commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

natemoo-re left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidwarrington commented Feb 2, 2026

Uh oh!

43081j commented Feb 3, 2026

Uh oh!

dreyfus92 commented Feb 4, 2026

Uh oh!

dreyfus92 commented Feb 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dreyfus92 commented Jan 31, 2026 •

edited

Loading

changeset-bot bot commented Jan 31, 2026 •

edited

Loading

pkg-pr-new bot commented Jan 31, 2026 •

edited

Loading