-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor coordinator logic and add sharded support #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bootjp
wants to merge
23
commits into
main
Choose a base branch
from
feature/multi-raft
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
7eb2044
Refactor coordinator logic and add sharded support
bootjp 7916d7d
Refactor SSH key handling and update .gitignore
bootjp 454b342
Fix go build command in Dockerfile
bootjp 607edc7
Refactor error messages into package-level variables
bootjp a081a09
plaintextFix alignment of error variable declarations
bootjp 122eff4
Update jepsen/src/elastickv/db.clj
bootjp f19cf76
Initial plan
Copilot 4ea2ac6
Initial plan
Copilot 13d2237
Update main.go
bootjp bcde8d2
Update kv/shard_store.go
bootjp f16c4bd
Fix ScanAt to only query groups with intersecting shard ranges
Copilot a35bc1a
Add .cache/ to .gitignore and remove from repository
Copilot 18933b5
Fix resource leaks in newRaftGroup error paths
Copilot 4b9881b
Add cache directories to .gitignore
Copilot ec0e6a5
Refactor cleanup logic to use helper function
Copilot c8c2d9f
Remove accidentally committed cache files
Copilot 2d344c9
Merge branch 'feature/multi-raft' into copilot/sub-pr-304
bootjp f3f2f58
Merge branch 'feature/multi-raft' into copilot/sub-pr-304-again
bootjp 5e43d88
Merge pull request #305 from bootjp/copilot/sub-pr-304
bootjp 61712fb
Merge branch 'feature/multi-raft' into copilot/sub-pr-304-again
bootjp b989eab
Update multiraft_runtime.go
bootjp c812a8b
Add comments clarifying resource cleanup logic
Copilot 21b8b9a
Merge pull request #306 from bootjp/copilot/sub-pr-304-again
bootjp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
maxLatestCommitTSfunction relies onr.store.LatestCommitTS()to determine the start timestamp for a transaction. However, the underlyingkv.ShardStore.LatestCommitTSimplementation performs a local read without verifying leadership or proxying to the leader. This can result in reading a stale commit timestamp if the current node is a follower for a shard. Using a stale timestamp to calculate the transaction'sstartTScan break snapshot isolation guarantees, as the transaction might read data from a point in time before a more recent write occurred.References