Make Collection Controls Aria Accessible#779
Merged
lcreid merged 11 commits intobootstrap-ruby:mainfrom Dec 3, 2025
Merged
Conversation
This commit also identified an error in existing code where `inline: true` on the collection field wasn't generating the right classes.
This was referenced Nov 25, 2025
Contributor
|
Hi just want to comment here that I think this is a step in the right direction and to thank you for all the work. Labels for radio buttons are being read now and I believe they fit the WCAG guidelines, though I'm not an expert on the matter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
collection_checkboxesandcollection_radio_buttonsproduce output that's more compliant with https://www.w3.org/WAI/tutorials/forms/grouping/#associating-related-controls-with-wai-aria.Since the markup changes noticeably, this change is only enabled by setting the configuration option
group_around_collections = true:This PR includes changes in the test files:
collection_checkboxesandcollection_radio_buttontests to their own files.collection_checkboxesandcollection_radio_buttonwith thegroup_around_collectionsoptions bothtrueandfalse.Eventually, this behaviour should become the default, and later, the old behavour should disappear altogether.
Closes: #763.