Skip to content

Comments

21 feat create diy for check#9374

Draft
gabo26126 wants to merge 2 commits intoborgbackup:masterfrom
DillwynKnox:21-feat-create-diy-for-check
Draft

21 feat create diy for check#9374
gabo26126 wants to merge 2 commits intoborgbackup:masterfrom
DillwynKnox:21-feat-create-diy-for-check

Conversation

@gabo26126
Copy link

@gabo26126 gabo26126 commented Feb 19, 2026

Description

Checklist

  • PR is against master (or maintenance branch if only applicable there)
  • New code has tests and docs where appropriate
  • Tests pass (run tox or the relevant test subset)
  • Commit messages are clean and reference related issues

Jribi-Mohamed-Aziz and others added 2 commits February 18, 2026 14:16
* [FEAT] DIY branch coverage instrumentation for ChunkerParams

* [FEAT] add missing branches

* [FEAT] remove reset function from coverage diy

---------

Co-authored-by: jribi <mohamed.jribi@epfl.ch>
@gabo26126
Copy link
Author

Test and coverage

@ThomasWaldmann
Copy link
Member

@gabo26126 Hmm, why would we want that "diy" coverage testing if we already have the pytest-cov / codecov based testing?

It seems rather intrusive to have to manage that everywhere.

@ThomasWaldmann
Copy link
Member

Also, the contributor names related to this PR seem to be all over the place?

@ThomasWaldmann
Copy link
Member

Please first open an issue on our issue tracker discussing what you intend to do here.

Like: what's the problem / motivation for this change, why it is needed and how you want to solve it.

@ThomasWaldmann ThomasWaldmann marked this pull request as draft February 19, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants