Run LaplacePetsc tests with 3D metric + various fixes#3283
Open
Run LaplacePetsc tests with 3D metric + various fixes#3283
LaplacePetsc tests with 3D metric + various fixes#3283Conversation
This test has significant overlap with other tests, it doesn't really give us any useful information
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- Remove comparison to default solver
- The default is cyclic which doesn't work with 3D metrics
- Also we don't actually do any comparison, so it doesn't help us test
anything
- Use one of PETSc's preconditioners instead of one of our solvers
- Prefer MUMPS but fall back to LU, which should always be available
- use field factory, rather than explicit loops
ZedThree
force-pushed
the
laplacepetsc-metric3d-zguard-fixes
branch
from
5bd5198 to
3ca3e68
Compare
Contributor
|
Out of interest, what was wrong with |
Member
Author
|
It doesn't work with 3D metrics because it uses FFTs. It's still used as the preconditioner in this test for non-3D metric builds though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-petsc_laplacewas disabled for 3D metric builds because it relied oncyclicas a preconditioner. This PR instead uses the PETScmumpsorlupreconditioners for 3D metrics instead.I did try
hypre, but that fails withNXPE > 1-- I didn't investigate too closely and just triedmumps. Not sure ifluis a sensible fallback, but it does seem to work.Also remove the tests of the default Laplacian solver from
test-petsc_laplace: we could just make them conditional on not using 3D metrics, but that complicates theruntestscript somewhat, and besides,cyclicis more thoroughly tested intest-laplace.Plus a bunch of related fixes:
LaplaceXYHypreas unavailable and disable its test for 3D metrics as they don't work togetherLaplaceimplementations that don't work with 3D metrics as unavailableLaplacePetscconstructor