Skip to content

Update galea_v4 config_board method to receive acknowledgements while streaming #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
retiutut wants to merge 1 commit into from
Closed

Update galea_v4 config_board method to receive acknowledgements while streaming #755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 37 additions & 41 deletions src/board_controller/openbci/galea_v4.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,58 +158,54 @@ int GaleaV4::config_board (std::string conf, std::string &response)
return (int)BrainFlowExitCodes::BOARD_WRITE_ERROR;
}

if (!is_streaming)
if (is_streaming)
{
char b[GaleaV4::max_transaction_size];
res = GaleaV4::max_transaction_size;
int max_attempt = 25; // to dont get to infinite loop
int current_attempt = 0;
while ((res >= 0) && (res % GaleaV4::package_size == 0))
safe_logger (spdlog::level::warn,
"reconfiguring device during the streaming may lead to inconsistent data, it's "
"recommended to call stop_stream before config_board");
}

char b[GaleaV4::max_transaction_size];
res = GaleaV4::max_transaction_size;
int max_attempt = 25; // to dont get to infinite loop
int current_attempt = 0;
while ((res >= 0) && (res % GaleaV4::package_size == 0))
{
res = socket->recv (b, GaleaV4::max_transaction_size);
if (res == -1)
{
res = socket->recv (b, GaleaV4::max_transaction_size);
if (res == -1)
{
#ifdef _WIN32
safe_logger (spdlog::level::err, "config_board recv ack WSAGetLastError is {}",
WSAGetLastError ());
safe_logger (spdlog::level::err, "config_board recv ack WSAGetLastError is {}",
WSAGetLastError ());
#else
safe_logger (spdlog::level::err, "config_board recv ack errno {} message {}", errno,
strerror (errno));
safe_logger (spdlog::level::err, "config_board recv ack errno {} message {}", errno,
strerror (errno));
#endif
return (int)BrainFlowExitCodes::BOARD_WRITE_ERROR;
}
current_attempt++;
if (current_attempt == max_attempt)
{
safe_logger (spdlog::level::err, "Device is streaming data while it should not!");
return (int)BrainFlowExitCodes::STREAM_ALREADY_RUN_ERROR;
}
}
// set response string
for (int i = 0; i < res; i++)
{
response = response + b[i];
return (int)BrainFlowExitCodes::BOARD_WRITE_ERROR;
}
switch (b[0])
current_attempt++;
if (current_attempt == max_attempt)
{
case 'A':
return (int)BrainFlowExitCodes::STATUS_OK;
case 'I':
safe_logger (spdlog::level::err, "invalid command");
return (int)BrainFlowExitCodes::INVALID_ARGUMENTS_ERROR;
default:
safe_logger (spdlog::level::warn, "unknown char received: {}", b[0]);
return (int)BrainFlowExitCodes::STATUS_OK;
safe_logger (spdlog::level::err, "Device is streaming data while it should not!");
return (int)BrainFlowExitCodes::STREAM_ALREADY_RUN_ERROR;
}
}
else
// set response string
for (int i = 0; i < res; i++)
{
safe_logger (spdlog::level::warn,
"reconfiguring device during the streaming may lead to inconsistent data, it's "
"recommended to call stop_stream before config_board");
response = response + b[i];
}
switch (b[0])
{
case 'A':
return (int)BrainFlowExitCodes::STATUS_OK;
case 'I':
safe_logger (spdlog::level::err, "invalid command");
return (int)BrainFlowExitCodes::INVALID_ARGUMENTS_ERROR;
default:
safe_logger (spdlog::level::warn, "unknown char received: {}", b[0]);
return (int)BrainFlowExitCodes::STATUS_OK;
}

return (int)BrainFlowExitCodes::STATUS_OK;
}

int GaleaV4::start_stream (int buffer_size, const char *streamer_params)
Expand Down
Loading