pool.end() resolves before the last pool.query()

[hjr3]

dupe of #3254 with 289273c to fix the failing test

[cloudflare-workers-and-pages]

Deploying node-postgres with    Cloudflare Pages

Latest commit:	289273c
Status:	✅  Deploy successful!
Preview URL:	https://6a8ab911.node-postgres.pages.dev
Branch Preview URL:	https://push-mpvwkrquvyqr.node-postgres.pages.dev

View logs

[hjr3]

note: if we want to merge this, then i should update the docs for https://node-postgres.com/apis/pool#remove to document the change in behavior

[brianc]

note: if we want to merge this, then i should update the docs for https://node-postgres.com/apis/pool#remove to document the change in behavior

Would you consider this a bug-fix or a breaking change? Seems to me like its a semantic alignment w/ expectations and more of a fix than a break, and no exising tests required changing so its more of a patch than a semver major. But I'd love to hear your thoughts!

[hjr3]

I agree this is a fix. No one expects pool.end to resolve before the last pool.query. Also, the documentation did not state that remove event is emitted prior to client end finishing.

edit:
Docs for remove event:

Whenever a client is closed & removed from the pool the pool will emit the remove event.

So, I would say that the expectation is that the client has been closed. Even more strongly in the "fix" camp. Maybe no change in behavior needs to be documented either.