[Chore] Include data files as part of packaging#24
Draft
adarshaks91 wants to merge 1 commit intomainfrom
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the gemspec to include all data files in the package by removing the file extension filter, and bumps the version to reflect this packaging fix.
- Updated gemspec to include all files under lib/ directory instead of only .rb and .json files
- Incremented version from 0.7.0 to 0.7.1
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/bmt/version.rb | Version bump to 0.7.1 |
| bmt.gemspec | Modified file inclusion pattern to capture all data files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| spec.homepage = 'https://github.com/bugcrowd/bmt-ruby' | ||
| spec.license = 'MIT' | ||
| spec.files = Dir['lib/**/*.{rb,json}'] | ||
| spec.files = Dir['lib/**/*'] |
There was a problem hiding this comment.
The wildcard pattern lib/**/* may include unintended files like backup files, temporary files, or development artifacts. Consider using a more specific pattern like Dir['lib/**/*.{rb,json,yml,yaml,xml,txt}'] to explicitly include only the data file types you need.
Suggested change
| spec.files = Dir['lib/**/*'] | |
| spec.files = Dir['lib/**/*.{rb,json,yml,yaml,xml,txt}'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Data files were not being included in the gemspec regex and hence were not being included in the package during the build