feat: add wit-bindgen Go packages #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
ricochet
reviewed
Jan 28, 2026
| "go.bytecodealliance.org/wit_runtime" | ||
| ) | ||
|
|
||
| const EVENT_NONE uint32 = 0 |
Contributor
There was a problem hiding this comment.
nit: constants should use iota:
const (
EVENT_NONE = iota
EVENT_SUBTASK
EVENT_STREAM_READ
// etc
ricochet
reviewed
Jan 28, 2026
| <head> | ||
| <title>go.bytecodealliance.org/cmd</title> | ||
| <meta name="go-import" content="go.bytecodealliance.org git https://github.com/bytecodealliance/componentize-go" /> | ||
| <meta http-equiv="refresh" content="0; url=https://pkg.go.dev/go.bytecodealliance.org/wit_async"> |
Contributor
There was a problem hiding this comment.
This does make me want to go ahead and bring over the wit package from go-modules so that we can do wit/async, wit/runtime, wit/types
ricochet
reviewed
Jan 28, 2026
| return offset | ||
| } | ||
|
|
||
| // Notify the host that the StreamReader is no longer being used. |
ricochet
reviewed
Jan 28, 2026
| } | ||
| pinner.Pin(buffer) | ||
|
|
||
| code, count := wit_async.FutureOrStreamWait(self.vtable.Read(handle, buffer, uint32(len(dst))), handle) |
Contributor
There was a problem hiding this comment.
I don't think this handles cancellation. Falls through to return count even for unexpected return codes. Consider adding an explicit panic or error handling for unknown codes.
ricochet
reviewed
Jan 28, 2026
ricochet
reviewed
Jan 28, 2026
ricochet
reviewed
Jan 28, 2026
| runtime.AddCleanup(value, func(_ int) { | ||
| handleValue := handle.TakeOrNil() | ||
| if handleValue != 0 { | ||
| vtable.DropReadable(handleValue) |
Contributor
There was a problem hiding this comment.
Shouldn't this be DropWritable
ricochet
reviewed
Jan 28, 2026
| runtime.AddCleanup(value, func(_ int) { | ||
| handleValue := handle.TakeOrNil() | ||
| if handleValue != 0 { | ||
| vtable.DropReadable(handleValue) |
Contributor
There was a problem hiding this comment.
Same here, seems like this should be DropWritable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.