filesystem: Paper over fadvise harmless failure on macos #12138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvolosatovs
reviewed
Dec 8, 2025
rvolosatovs
reviewed
Dec 8, 2025
wingo
force-pushed
the
macos-fadvise-willneed-oob
branch
from
db95e26 to
6a351af
Compare
On macos and ios, fadvise is only implemented for WillNeed and dispatches via the system-interface crate to the F_RDADVISE fcntl. If you call WillNeed on an out-of-bounds offset, this fcntl returns FileTooLarge. Here we paper over this harmless error code to avoid this needless platform-dependent nonuniformity. Should fix wasmtime for WebAssembly/wasi-testsuite#178. prtest:full
wingo
force-pushed
the
macos-fadvise-willneed-oob
branch
from
6a351af to
1da615b
Compare
wingo
commented
Dec 15, 2025
| return Ok(()); | ||
| } | ||
|
|
||
| Err(code) |
Contributor
Author
There was a problem hiding this comment.
I find this patch to be pretty gross, for a few reasons:
advicedoesn't implement copy, so it gets moved into the closure; have to check it beforehand, making it less amenable to#[cfg]- the whole system error vs errorcode thing; can't match on
FileTooLargedirectly, only onerr.into() ErrorCodedoesn't implementPartialEq, so no==
Any style tips are very welcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macos and ios, fadvise is only implemented for WillNeed and dispatches via the system-interface crate to the F_RDADVISE fcntl. If you call WillNeed on an out-of-bounds offset, this fcntl returns FileTooLarge. Here we paper over this harmless error code to avoid this needless platform-dependent nonuniformity. Should fix wasmtime for WebAssembly/wasi-testsuite#178.