Skip to content

Conversation

@tamaroning
Copy link

FIx #12161

@tamaroning tamaroning marked this pull request as ready for review December 12, 2025 14:15
@tamaroning tamaroning requested review from a team as code owners December 12, 2025 14:15
@tamaroning tamaroning requested review from cfallin and removed request for a team December 12, 2025 14:15
@tamaroning
Copy link
Author

Can someone tell me how to fix CI to pass?

@cfallin
Copy link
Member

cfallin commented Dec 12, 2025

The failing CI job is right to fail: it's indicating that pulling in the new library requires new vetting. One of the core team members will have to do a cargo vet.

I'm tagged as reviewer here but I have some high-priority stuff on my plate at the moment so it may not be until sometime next week when I get to this, sorry!

Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I had some time to do the vets and the changes here look good. Thanks!

@cfallin cfallin enabled auto-merge December 12, 2025 22:03
@tamaroning
Copy link
Author

Understand. Thank you!

@cfallin
Copy link
Member

cfallin commented Dec 13, 2025

@tamaroning I think this needs a Cargo.lock update as well (see the CI failures); would you mind doing that by doing cargo check or cargo build and then adding the updates as a new commit? (Please do not alter my vet commit; 0da9d0b needs to remain on this branch.)

@tamaroning
Copy link
Author

Hi, I ran cargo update at your commit but nothing in Cargo.lock changed.
Do you mean cargo update?

auto-merge was automatically disabled December 13, 2025 19:03

Head branch was pushed to by a user without write access

@cfallin
Copy link
Member

cfallin commented Dec 14, 2025

Hi, I ran cargo update at your commit but nothing in Cargo.lock changed. Do you mean cargo update?

No, I didn't mean cargo update -- that pulls in new versions that require more vets. Would you mind force-pushing back to the prior commit to remove your latest one? (i.e., start from 0da9d0b again)

Please see the CI job failure here: that is showing that after running several cargo check commands on different crates, the lockfile is modified. You'll need to reproduce that and then create a new, separate commit on top with those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to compile wasmtime-wasi-nn with onnx support

2 participants