6.x: Add stricter naming convention sniffs #424
Draft
+44
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces stricter naming convention enforcement for CakePHP 6.x, aligned with PSR naming conventions.
New Sniffs
ValidPropertyNameSniff (new)
$_propertyName)ValidFunctionNameSniff (updated)
_getFieldName(),_setFieldName())$_magicMethodsproperty naming (was using underscore prefix itself)Ruleset Changes
PSR2.Classes.PropertyDeclaration.Underscoreexclusion - PSR2 property underscore checks now applyRequireNullCoalesceEqualOperator- Require??=operatorRequireNullSafeObjectOperator- Require?->operatorRequireSelfReference- Requireself::instead of class nameNullTypeHintOnLastPosition- Enforcestring|nullinstead ofnull|stringMigration
Projects upgrading to CakePHP 6.x should:
$_propertyName→$propertyName_methodName()→methodName()The cakephp/upgrade tool has Rector rules to automate these renames.
Tests
All existing tests pass, new test cases added for: