Conversation
markstory
reviewed
Nov 14, 2025
| $authorizationService = $this->getRequest()->getAttribute('authorization'); | ||
| if ($authorizationService instanceof AuthorizationService) { | ||
| if (Configure::read('DebugKit.ignoreAuthorization')) { | ||
| if (Configure::read('DebugKit.ignoreAuthorization') !== false) { |
Member
There was a problem hiding this comment.
We had defaulted to off to take care of the inevitable situation of someone deploying with debug on. The hope was that folks wouldn't also deploy this config option.
Member
Author
There was a problem hiding this comment.
Thats highly unlikely, as this is usually a committed config setting then (not a app_local one) :)
So not really protecting anyone here IMO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whats the whole point of this flag if that action is only to be used in debug mode
And debug mode by definition should only be a local dev thing (thus access should be granted).
Having to set this flag for all apps is quite annoying, and I dont really see any security relevant point in it.
For now you can still disable using
but I dont quite see the point here for DebugKit and debug mode on (the only way it can actually work and display things anyway).