-
Notifications
You must be signed in to change notification settings - Fork 8
Add configurable underscore command naming #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add TwigView.useUnderscoreCommands config option - When true: registers `twig_view compile` (new style) - When false/unset: registers `twig-view compile` (deprecated) - Add config/app.example.php documenting available options - Add PHPUnit 12 support 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
I doubt anyone is going to notice or use this config. Another solution is adding both |
|
Yeah thats why the config: It allows the upgrade for those that want it, everyone else can safely ignore. No duplicate or weird display either way. |
|
But this config doesn't provide us a deprecation based upgrade path as we do for classes/methods, continue use of existing API with a deprecation while adding a new one. |
|
As this is purely opt-in. If you think it is important you can also add a deprecation note of course to alert the user. |
|
Might be simpler to add both and just change it in a release. |
I dont follow. This PR seems ready and working as is IMO. Simple, yet effective, until next major. |
|
Do what you want then. |
Can you explain what you mean with both? You want both parallel inside the CLI output for bin/cake? |
|
Feel free to make an alternative PR if you do not want to move forward with this clear forward path solution.
Option A for those that care, everyone else can continue to ignore until next major. Simple. |
|
I don't think it needs that much of a debate. The config is unlikely to be used, but no harm in adding it if you want a transition. |
|
Yeah, agreed. Any way forward is good. Alternative PRs can be made if anyone feels strongly about it. |
Refs cakephp/cakephp#19086
Unfortunately, CakePHP's CommandCollection doesn't have a built-in mechanism to hide specific command aliases from the list - the hidden property on Command
classes applies to the command itself regardless of which name it's invoked with. Both will appear in bin/cake output, but both will work identically.
So we need a feature flag switch
Summary
TwigView.useUnderscoreCommandsconfig option for command naming styletrue: registerstwig_view compile(new underscore style)false/unset: registerstwig-view compile(deprecated hyphen style)config/app.example.phpdocumenting available optionsUpgrade path
twig_view compile'TwigView.useUnderscoreCommands' => truein configWe should be able to release this as a minor