-
Notifications
You must be signed in to change notification settings - Fork 155
fix: hermes-compiler path for RN 0.82+ in the hermes bytecode plugin #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2973650 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@ismarbesic is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
jbroma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thank you for your contribution 🎉
The change looks good, I see that you have also included the compatibility for previous RN versions 🚀
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jbroma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
|
Thanks again for your contribution @ismarbesic 🎉 |
Summary
The path of the
hermescbinary was recently changed to support bundling the app using hermes v1, see facebook/react-native#53581. This makes the HermesBytecodePlugin fail since the old path isn't present anymore in React Native 0.82+. This PR adds support for the new path while preserving a fallback to the old path.Test plan