fix: preserve tags in property-based identification (#1391) #1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you @normenmueller . This is a good fix! Merging. |
callumalpass
added a commit
that referenced
this pull request
Jan 6, 2026
…fication (#1391) Property-based task identification no longer mutates tags. Tags are only written when explicitly set by the user, and the task tag is only added in tag-based mode. - Only add identifying task tag when using tag-based identification - Preserve user tags without filtering in property mode - Only write frontmatter.tags when tags are explicitly changed - Edit modal shows all tags in property mode, tracks changes correctly Fixes #1391. Many thanks to @normenmueller for the contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix-task-prop-based-ident
Property-based task identification preserves tags
This change prevents property-based identification from mutating tags automatically. Tags are only written when the user explicitly sets them (including default tags), while the identifying property is still applied.
Examples (illustrative):
client, urgentkeeps those tags; no extra task tag is injected.Changelog
Task Identification
frontmatter.tagsduring updates when tags are explicitly provided; otherwise leave tags untouched.Cf. PR.md