Conversation
These imports in app.ts were skipping a level in the package dependency graph. ember-power-select and ember-power-calendar are not dependencies of host, they're dependencies of boxel-ui. Trying to import from your dep's deps is unreliable and makes the vite depscan complain. I pushed them down into the boxel-ui components that actually pull the corresponding ember-power-* components into the project.
Under vite, we don't use an AMD loader so we won't conflict with the one in monaco.
Host Test Results 1 files ± 0 1 suites ±0 6h 59m 9s ⏱️ + 5h 19m 46s For more details on these failures and errors, see this check. Results for commit 7e81686. ± Comparison against base commit c2e3fb9. This pull request removes 788 and adds 10 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Preview deployments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.