DRAFT: Submission bot opens a github PR by tintinthong · Pull Request #4044 · cardstack/boxel

tintinthong · 2026-02-23T14:46:36Z

No description provided.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 935b2c0665

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-23T14:51:35Z

packages/bot-runner/lib/github.ts

+      let prParams: Parameters<CreatePullRequest>[0] = {
+        ...params,
+        head: HARDCODED_PR_HEAD_BRANCH,
+      };


Respect caller-provided PR head branch

openPullRequest currently replaces params.head with a hardcoded branch, so every PR is opened from test-submissions regardless of the event/listing-specific branch passed by callers. This breaks branch isolation and can open the wrong PR (or fail if that branch is absent), which makes the submission flow unreliable for any room-specific listing updates.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-02-23T14:51:35Z

packages/bot-runner/lib/timeline-handler.ts

+    if (eventContent.type === 'pr-listing-create') {
+      // Temporary workaround: handle PR creation directly until this flow is moved to a proper command path.
+      await openCreateListingPR({
+        eventContent,


Return after direct pr-listing-create handling

For pr-listing-create, this function calls openCreateListingPR but then continues into the generic enqueue path instead of exiting, so the same trigger can both open a PR directly and enqueue a run-command job. In environments where that event type has an allowed command registration, this causes duplicated/competing side effects for a single Matrix event.

Useful? React with 👍 / 👎.

github-actions · 2026-02-23T15:00:16Z

Preview deployments

github-actions · 2026-02-23T15:13:33Z

Host Test Results

1 files ±0 1 suites ±0 1h 33m 21s ⏱️ - 3m 27s
1 869 tests +2 1 854 ✅ +2 15 💤 ±0 0 ❌ ±0
1 884 runs +2 1 869 ✅ +2 15 💤 ±0 0 ❌ ±0

Results for commit b9ab851. ± Comparison against base commit 2bfa7ec.

♻️ This comment has been updated with latest results.

…mand

Copilot

Pull request overview

This pull request implements a submission bot feature that automates the creation of GitHub pull requests for catalog listings. The bot listens to Matrix events, processes submission requests, collects listing files, and creates PRs in the boxel-catalog repository.

Changes:

Added GitHub API integration using Octokit for creating branches, commits, and pull requests
Implemented submission workflow with create-submission command that generates SubmissionCard instances
Refactored bot-runner timeline handling to support the new pr-listing-create event type with userId tracking

Reviewed changes

Copilot reviewed 32 out of 33 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pnpm-lock.yaml	Added `@octokit/rest` and `@octokit/types` dependencies for GitHub API integration
packages/runtime-common/github-submissions.ts	New module for encoding/decoding Matrix room IDs into branch names using base64url
packages/runtime-common/tests/github-submissions-test.ts	Test coverage for branch name encoding and submission metadata extraction
packages/runtime-common/bot-trigger.ts	Added required userId field to BotTriggerEvent validation
packages/runtime-common/index.ts	Exported github-submissions module
packages/base/matrix-event.gts	Added userId field to BotTriggerContent interface
packages/base/command.gts	Added CreateSubmissionInput and CreateSubmissionResult types
packages/host/app/commands/create-submission.ts	New command to prepare submission data and create SubmissionCard instances
packages/host/app/commands/index.ts	Registered CreateSubmissionCommand in the command registry
packages/host/app/commands/bot-requests/send-bot-trigger-event.ts	Added userId to bot trigger events
packages/host/app/commands/bot-requests/create-listing-pr-request.ts	Updated to use pr-listing-create event type and include listingName
packages/host/tests/integration/commands/*	Test coverage for bot trigger events and submission creation
packages/bot-runner/lib/github.ts	New GitHub client implementation using Octokit for PR operations
packages/bot-runner/lib/create-listing-pr-handler.ts	Handler for pr-listing-create events including branch creation and PR opening
packages/bot-runner/lib/command-runner.ts	Command runner with special handling for pr-listing-create workflow
packages/bot-runner/lib/timeline-handler.ts	Refactored to use CommandRunner for event processing
packages/bot-runner/tests/*	Comprehensive test coverage for GitHub operations and command handling
packages/bot-runner/main.ts	Integrated GitHub client into bot-runner initialization
packages/bot-runner/package.json	Added Octokit dependencies
packages/catalog-realm/submission-card/submission-card.gts	New SubmissionCard definition for tracking submissions
packages/catalog-realm/*	Added submission card listing and demo instance
packages/matrix/scripts/setup-submission-bot.ts	Updated to register create-submission command for pr-listing-create events
packages/experiments-realm/bot-request-demo.gts	Updated demo to use pr-listing-create event type
docs/*	Added comprehensive documentation for the submission flow

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/bot-runner/tests/create-listing-pr-handler-test.ts

Copilot · 2026-02-25T14:16:26Z

docs/catalog-submission-flow.md

+
+Headless command execution details are documented here:
+
+- [commands-in-headless-chrome.md](/Users/tintinthong/github/boxel/docs/commands-in-headless-chrome.md)


This documentation link contains an absolute path to a user's local file system ("/Users/tintinthong/github/boxel/..."). This should be a relative path like "commands-in-headless-chrome.md" or "./commands-in-headless-chrome.md".

Suggested change

- [commands-in-headless-chrome.md](/Users/tintinthong/github/boxel/docs/commands-in-headless-chrome.md)

- [commands-in-headless-chrome.md](./commands-in-headless-chrome.md)

Copilot · 2026-02-25T14:16:26Z

packages/bot-runner/lib/github.ts

+  commitSha: string;
+}
+
+const HARDCODED_REVIEWER = 'tintinthong';


The HARDCODED_REVIEWER constant contains a specific GitHub username ('tintinthong'). This should be configurable via an environment variable to allow different reviewers for different deployments or to support multiple reviewers.

Suggested change

const HARDCODED_REVIEWER = 'tintinthong';

const HARDCODED_REVIEWER = process.env.GITHUB_DEFAULT_REVIEWER ?? 'tintinthong';

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b9ab851b3b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-25T14:18:56Z

packages/bot-runner/lib/command-runner.ts

+        let result: RunCommandResponse = await job.done;
+        await this.createListingPRHandler.addContentsToCommit(eventContent, result);
+        await this.createListingPRHandler.openCreateListingPR(


Skip PR side effects when run-command fails

The pr-listing-create branch continues into addContentsToCommit/openCreateListingPR even when job.done resolves to a non-ready result. run-command returns { status: 'error', error: ... } for common failures (permissions/invalid command input) without throwing, so this path can create an empty branch and then silently exit on “No commits between” instead of surfacing the real failure. Gate the GitHub write/PR steps on result.status === 'ready' and propagate result.error when it is not.

Useful? React with 👍 / 👎.

tintinthong · 2026-02-25T15:35:38Z

fileContent field is fine as FieldDef bcos it creates a snapshot
remove labels pls and just create the submission without labels. put all info in body of PR

tintinthong changed the base branch from main to get-bot-runner-to-run-headless-command February 23, 2026 14:47

chatgpt-codex-connector bot reviewed Feb 23, 2026

View reviewed changes

tintinthong marked this pull request as draft February 23, 2026 14:52

tintinthong force-pushed the get-bot-runner-to-run-headless-command branch from 6317949 to 2bfa7ec Compare February 25, 2026 04:21

tintinthong added 7 commits February 25, 2026 12:25

wip

b47ded8

doNotWaitForPersist so no timeout

bcbe257

get submission bot to open a branch with contents returned from a com…

db22c18

…mand

simplify timeline-handler

dbc596c

refactor oop style

c2d727d

delete previous submissions

ece81be

fix submission card

ff1a5c3

tintinthong force-pushed the cs-9945-submission-bot-open-a-github-pr branch from 49fabaa to ff1a5c3 Compare February 25, 2026 09:18

tintinthong added 2 commits February 25, 2026 18:10

fix naming

d1e15f9

add submission flow documentaiton

b9ab851

tintinthong requested a review from Copilot February 25, 2026 14:09

tintinthong marked this pull request as ready for review February 25, 2026 14:09

Copilot started reviewing on behalf of tintinthong February 25, 2026 14:10 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DRAFT: Submission bot opens a github PR #4044

DRAFT: Submission bot opens a github PR #4044
tintinthong wants to merge 9 commits intoget-bot-runner-to-run-headless-commandfrom
cs-9945-submission-bot-open-a-github-pr

tintinthong commented Feb 23, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 23, 2026

Uh oh!

chatgpt-codex-connector bot Feb 23, 2026

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

github-actions bot commented Feb 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 25, 2026

Uh oh!

tintinthong commented Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		Headless command execution details are documented here:

		- [commands-in-headless-chrome.md](/Users/tintinthong/github/boxel/docs/commands-in-headless-chrome.md)

	- [commands-in-headless-chrome.md](/Users/tintinthong/github/boxel/docs/commands-in-headless-chrome.md)
	- [commands-in-headless-chrome.md](./commands-in-headless-chrome.md)

	const HARDCODED_REVIEWER = 'tintinthong';
	const HARDCODED_REVIEWER = process.env.GITHUB_DEFAULT_REVIEWER ?? 'tintinthong';

Conversation

tintinthong commented Feb 23, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 23, 2026

Preview deployments

Uh oh!

github-actions bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Host Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

tintinthong commented Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Feb 23, 2026 •

edited

Loading