Filter cards by type in Recents Section of Card Picker by burieberry · Pull Request #4066 · cardstack/boxel

burieberry · 2026-02-25T22:09:44Z

Recents section was missing the type filter for the following cases:

Create New card instance
Add card to LinksTo field
Add card to LinksToMany field
Find Instances in code mode

github-actions · 2026-02-25T22:17:07Z

Preview deployments

github-actions · 2026-02-25T22:28:38Z

Host Test Results

1 files ± 0 1 suites ±0 1h 46m 12s ⏱️ + 12m 22s
1 902 tests +23 1 887 ✅ +23 15 💤 ±0 0 ❌ ±0
1 917 runs +23 1 902 ✅ +23 15 💤 ±0 0 ❌ ±0

Results for commit 9189ca6. ± Comparison against base commit 61ceac3.

This pull request removes 7 and adds 30 tests. Note that renamed tests count towards both.

Chrome ‑ Acceptance | code submode | create-file tests > when user has permissions to both test realms: new file button has options to create card def, field def, card instance, and text files
Chrome ‑ Integration | operator-mode | card catalog: Recents section filters cards by realm
Chrome ‑ Integration | operator-mode | card catalog: Recents section filters cards by search key
Chrome ‑ Integration | operator-mode | card catalog: Recents section hides cards from unselected realms
Chrome ‑ Integration | operator-mode | card catalog: Recents section is present when search sheet is open (expanded mode)
Chrome ‑ Integration | operator-mode | card catalog: displays recently accessed card
Chrome ‑ Integration | operator-mode | card catalog: displays recently accessed card, maximum 10 cards

Chrome ‑ Acceptance | code submode | create-file tests > when user has permissions to both test realms: can upload a file via the New menu
Chrome ‑ Acceptance | code submode | create-file tests > when user has permissions to both test realms: cancelling upload file picker does not cause errors
Chrome ‑ Acceptance | code submode | create-file tests > when user has permissions to both test realms: new file button has options to create card def, field def, card instance, text files, and upload file
Chrome ‑ Acceptance | code submode | file-tree tests > when the user lacks write permissions: file tree does not show context menu in read-only realm
Chrome ‑ Acceptance | code submode | file-tree tests: can cancel delete from file tree context menu
Chrome ‑ Acceptance | code submode | file-tree tests: can delete a file from file tree context menu
Chrome ‑ Acceptance | code submode | file-tree tests: can delete a file via right-click in file tree
Chrome ‑ Acceptance | file chooser tests: uploading a file without an extension shows an error
Chrome ‑ Integration | operator-mode | card catalog > recents section: displays recently accessed card
Chrome ‑ Integration | operator-mode | card catalog > recents section: displays recently accessed card, maximum 10 cards
…

♻️ This comment has been updated with latest results.

lukemelia · 2026-02-25T23:13:59Z

packages/host/app/components/card-search/search-content.gts

+  private get filterTypeRef(): CodeRef | undefined {
+    const filter = this.args.baseFilter;
+    if (filter) {
+      // EveryFilter with 'on' scoping (e.g. specRef in chooseCard)
+      if ('on' in filter && filter.on) {
+        return filter.on;
+      }
+      // Top-level CardTypeFilter { type: CodeRef } (e.g. linksTo)
+      if (isCardTypeFilter(filter)) {
+        return filter.type;
+      }
+      // EveryFilter containing a CardTypeFilter (e.g. linksToMany)
+      if (isEveryFilter(filter)) {
+        for (const sub of filter.every) {
+          if (isCardTypeFilter(sub)) {
+            return sub.type;
+          }
+        }
+      }
+      return undefined;
+    }
+    // Search-sheet mode: extract type from carddef: search key (searchForInstances)
+    return getCodeRefFromSearchKey(this.args.searchKey);
+  }
+


This seems like it might belong in a query-utils module with unit tests

I have added this as getTypeRefsFromFilter utility function in query-field-utils and also expanded the logic to handle types in other filter kinds and more complex filters.

… unit tests

Copilot

Pull request overview

Adds missing type-based filtering for the Recents section in the card picker / search UI flows (create card, linksTo/linksToMany pickers, and “Find Instances” in code mode), so Recents aligns with the active type constraints.

Changes:

Introduces getTypeRefsFromFilter() in runtime-common to extract type refs (including negations) from query Filters.
Applies extracted type constraints to Recents filtering in SearchContent.
Adds unit + integration tests and a new data-test-recent-card-result hook for asserting Recents behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`packages/runtime-common/query-field-utils.ts`	Adds `getTypeRefsFromFilter()` helper to extract type refs from filters.
`packages/host/app/components/card-search/search-content.gts`	Applies type filtering to Recents using extracted type refs (and `carddef:` search key in search-sheet mode).
`packages/host/app/components/card-search/search-result-section.gts`	Adds `data-test-recent-card-result` attribute for Recents items to support assertions.
`packages/host/tests/unit/get-type-refs-from-filter-test.ts`	Adds unit coverage for `getTypeRefsFromFilter()` behavior.
`packages/host/tests/integration/components/operator-mode-card-catalog-test.gts`	Expands Recents integration coverage including new type-filtering scenarios.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-26T18:05:52Z

packages/host/app/components/card-search/search-content.gts


+function cardMatchesTypeRef(card: CardDef, typeRef: CodeRef): boolean {
+  if (!isResolvedCodeRef(typeRef)) {
+    return false;


cardMatchesTypeRef returns false for any non-ResolvedCodeRef (e.g. CodeRef shapes like { type: 'fieldOf' | 'ancestorOf', ... }). Since getTypeRefsFromFilter() can return these (and chooseCardTitle() already supports them via loadCardDef), this can cause the recents list to be filtered down to zero even when there are matching recent cards. Consider either resolving non-resolved CodeRefs to a concrete card def (via loadCardDef + identifyCard/prototype checks) before filtering, or skipping type filtering when the extracted type refs are not resolvable (instead of filtering everything out).

Suggested change

return false;

// For non-resolved CodeRefs (e.g. fieldOf/ancestorOf), we cannot

// concretely determine a mismatch here. Treat them as a no-op filter

// rather than excluding the card, so recents are not over-filtered.

return true;

Copilot · 2026-02-26T18:05:52Z

packages/host/tests/integration/components/operator-mode-card-catalog-test.gts


-    // expand search sheet
-    await fillIn('[data-test-search-field]', ' ');
+      // Simulate searchForInstances for Person — carddef: prefix + absolute module/name key


The inline comment says this simulates searchForInstances for "Person", but the carddef: search key being entered is for pet/Pet. Update the comment to match the actual type being searched to avoid confusion when maintaining this test.

Suggested change

// Simulate searchForInstances for Person — carddef: prefix + absolute module/name key

// Simulate searchForInstances for Pet — carddef: prefix + absolute module/name key

burieberry added 4 commits February 25, 2026 16:06

initial attemp

e068e82

use identify card instead of loadCardDef

e4b558a

filter recents by type for "Find Instances"

70e3c25

move recents tests into module

9d95059

improve tests

7ebcd67

burieberry marked this pull request as ready for review February 25, 2026 23:08

burieberry requested a review from a team February 25, 2026 23:08

lukemelia approved these changes Feb 25, 2026

View reviewed changes

burieberry added 6 commits February 26, 2026 10:32

move getTypeRefFromFilter to runtime-common/query-field-utils and add…

8435ee7

… unit tests

test clean up

d3849d7

handle any-filter case

15b3aed

handle negation for NotFilter

5030cf4

fix sortedRecentCards' handling of filterTypeRefs

8d6f83b

add comment

9189ca6

habdelra requested a review from Copilot February 26, 2026 17:58

Copilot started reviewing on behalf of habdelra February 26, 2026 17:58 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

burieberry merged commit 86a8f76 into main Feb 26, 2026
110 of 111 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Filter cards by type in Recents Section of Card Picker#4066

Filter cards by type in Recents Section of Card Picker#4066
burieberry merged 11 commits intomainfrom
cs-10261-create-new-via-recents

burieberry commented Feb 25, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026 •

edited

Loading

Uh oh!

lukemelia Feb 25, 2026

Uh oh!

burieberry Feb 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-    return false;
+    // For non-resolved CodeRefs (e.g. fieldOf/ancestorOf), we cannot
+    // concretely determine a mismatch here. Treat them as a no-op filter
+    // rather than excluding the card, so recents are not over-filtered.
+    return true;

	// Simulate searchForInstances for Person — carddef: prefix + absolute module/name key
	// Simulate searchForInstances for Pet — carddef: prefix + absolute module/name key

Conversation

burieberry commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 25, 2026

Preview deployments

Uh oh!

github-actions bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Host Test Results

Uh oh!

lukemelia Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

burieberry Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

burieberry commented Feb 25, 2026 •

edited

Loading

github-actions bot commented Feb 25, 2026 •

edited

Loading