feat: create Svelte framework integration #4063
Conversation
clockwork-tien
force-pushed
the
tien/feat/svelte-integration
branch
from
398befc to
0124d6e
Compare
| } | ||
| } | ||
|
|
||
| function formatValue(v: Value): string { |
There was a problem hiding this comment.
Much of this code is duplicated across Vue, React, Svelte. Can we please consolidate it into a shared file?
There was a problem hiding this comment.
Im not certain that its worth for now since maybe we could reuse the ts client side query builder for the where clause logic? 🤔 i definetly wanna look into that when that pr lands :> But understandable if its better consolidated now and deleted now later 👍
In case you do end up consolidating it please keep the react version since there i added uuid support for the where clause 😇
| import { useSpacetimeDB, useTable, useReducer } from 'spacetimedb/svelte'; | ||
| import { tables, reducers } from './module_bindings'; | ||
|
|
||
| const conn = useSpacetimeDB(); |
There was a problem hiding this comment.
Is this idiomatic for Svelte? See: https://discord.com/channels/@me/1414626136121676017/1463374453193834506
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
This generally looks good to me. Just two questions/comments in the code.
Description of Changes
The PR implements the following updates:
svelte-tstemplateScreenshots
svelte-tstemplateAPI and ABI breaking changes
Expected complexity level and risk
Testing