Make all VmMetrics for the reducers and views of a module in InstanceCommon::new
#4106
+104
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
With this PR, all
VmMetricsfor all the reducers and views of a module are made inInstanceCommon::newso that they are never made in
call_{reducer/view}_with_tx.Here's a flamegraph before this PR, zooming in on the smaller
call_reducer_with_txAnd after, for the same
call_reducer_with_tx:Here are the performance numbers:
As you can see, this is a gain of about 6k TPS on the phoenix_nap machine.
The second commit also adds the
d3-flamegraph-base.htmland stuff to.gitignoreto facilitate taking flamegraphs.API and ABI breaking changes
None
Expected complexity level and risk
1, trivial changes that are not load bearing.