cljs.proxy doesn't handle for .. of correctly#298
Merged
swannodette merged 3 commits intomasterfrom Nov 30, 2025
Merged
Conversation
Member
swannodette
commented
Nov 30, 2025
swannodette
commented
- check for Symbol.iterator case in vec and map handler
- need to bind iterator to target for it to work
- fixes trivial vector case [1 2 3 4], but not nested case
- will need to map over the results of the iterator
- this true for the map case too where entries are 2-element arrays
- check for Symbol.iterator case in vec and map handler
- need to bind iterator to target for it to work
- fixes trivial vector case [1 2 3 4], but not nested case
* will need to map over the results of the iterator
* this true for the map case too where entries are 2-element
arrays
- remove string cases - remove iterator cases from map-handler, no for..of for raw Objects
swannodette
changed the title
for .. in correctlyfor .. of correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.