Avoid redundant domain name entry#215
Open
pmeinhardt wants to merge 1 commit intocloudcomponents:cdk2from
Open
Avoid redundant domain name entry#215pmeinhardt wants to merge 1 commit intocloudcomponents:cdk2from
pmeinhardt wants to merge 1 commit intocloudcomponents:cdk2from
Conversation
Previously, the first domain name was passed to the `DnsValidatedCertificate` construct twice. In the `domainName` prop and again in the `subjectAlternativeNames`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the first domain name was passed to the
DnsValidatedCertificateconstruct twice.In the
domainNameprop and again in thesubjectAlternativeNames.For example, when using
new StaticWebsite(app, "Website", { domainNames: ["example.org"], … }), the wildcard domain*.example.orgwas specified twice.For reference, see the corresponding code in
DnsValidatedCertificate.There is one thing I was not able to verify yet. The value of
subjectAlternativeNamesis used in one more place in theDnsValidatedCertificateconstruct:https://github.com/aws/aws-cdk/blob/v2.153.0/packages/aws-cdk-lib/aws-certificatemanager/lib/dns-validated-certificate.ts#L147
The custom resource also receives
domainNameseparately, but I couldn't tell whether removing it from thesubjectAlternativeNamesmight have any side effects here.Kind regards,
Paul