[cdk-responsive-email-template] Upgrade to CDK v2; Upgrade dependencies#220
Open
e-pavlica wants to merge 1 commit intocloudcomponents:masterfrom
Open
[cdk-responsive-email-template] Upgrade to CDK v2; Upgrade dependencies#220e-pavlica wants to merge 1 commit intocloudcomponents:masterfrom
e-pavlica wants to merge 1 commit intocloudcomponents:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
@cloudcomponents/cdk-responsive-email-templateto use CDK v2.I originally forked this because of a vulnerability alert in the
html-minifierdependency; as it appears that package is no longer maintained I switched it tohtml-minifier-next. This does not actually solve the vulnerable dependency issue, asmjmlalso relies onhtml-minifier. I'm reticent to use analphatag, but upgradingmjmlto>=5.0.0-alpha.0would resolve the issues raised bynpm auditfor this package. If the maintainers here think that is appropriate change I'll happily apply that upgrade as well.I don't have a lot of experience using yarn / lerna so please let me know if I didn't do something right with this upgrade process.