Skip to content

Conversation

@cloudinary-pkoniu
Copy link
Contributor

Brief Summary of Changes

Multiple fixes/rewrites in a single PR:

  • chore: url parsing done via native url package
  • fix: unhandled promise rejection caused by removal of Q
  • fix: hanging socket connections are closed properly by ensuring that a response is consumed
  • fix: jsdom-global overwriting globally available url package
  • chore: mocha always exists even if connections are hanging

What Does This PR Address?

Are Tests Included?

  • Yes
  • No

Reviewer, Please Note:

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've added some non blocking (in my opinion) comments

@cloudinary-pkoniu cloudinary-pkoniu merged commit 0905db9 into master Dec 31, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants