Skip to content

Commiter includes Version and Hash #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasMichael1811 merged 1 commit into from
Dec 17, 2025
Merged

Commiter includes Version and Hash #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file removed src/main/groovy/com/cloudogu/gitops/features/ScmManagerSetup.groovy
View file
Open in desktop
Empty file.
3 changes: 2 additions & 1 deletion src/main/groovy/com/cloudogu/gitops/git/GitRepo.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.cloudogu.gitops.git

import com.cloudogu.gitops.cli.Version
import com.cloudogu.gitops.config.Config
import com.cloudogu.gitops.git.jgit.helpers.InsecureCredentialProvider
import com.cloudogu.gitops.git.providers.AccessRole
Expand Down Expand Up @@ -106,7 +107,7 @@ class GitRepo {
.setSign(false)
.setMessage(commitMessage)
.setAuthor(gitName, gitEmail)
.setCommitter(gitName, gitEmail)
.setCommitter("${gitName} - GOP v${Version.NAME.split(',')[0].replace('(','')}", gitEmail) //parsing the Versions from the full text in Version.Name. In local Dev there is no Tag->Version is empty
.call()

def pushCommand = createPushCommand(refSpec)
Expand Down
2 changes: 1 addition & 1 deletion src/test/groovy/com/cloudogu/gitops/git/GitRepoTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ class GitRepoTest {
assertThat(commits[0].authorIdent.emailAddress).isEqualTo('hello@cloudogu.com')
assertThat(commits[0].authorIdent.name).isEqualTo('Cloudogu')
assertThat(commits[0].committerIdent.emailAddress).isEqualTo('hello@cloudogu.com')
assertThat(commits[0].committerIdent.name).isEqualTo("Cloudogu")
assertThat(commits[0].committerIdent.name).contains("Cloudogu - GOP v")

List<Ref> tags = Git.open(new File(repo.absoluteLocalRepoTmpDir)).tagList().call()
assertThat(tags.size()).isEqualTo(0)
Expand Down