Draft
Conversation
1. with saving/loading cache to/from disk 2. fixes the missing client.Close
optimizes getSymbolByLocation() and filterLocalSymbols()
welkeyever
reviewed
Sep 12, 2025
|
|
||
| import "github.com/cloudwego/abcoder/lang/lsp" | ||
|
|
||
| func isFuncLike(sk lsp.SymbolKind) bool { |
Member
There was a problem hiding this comment.
Who is the caller of these three functions?
Collaborator
Author
There was a problem hiding this comment.
skipTokenForDependency and getSymbolByLocation in Collect.go. I thought this might help with clarifying & maintaining consistency tho.
Collaborator
Author
|
The optimizations are real, but let's not merge this for now. The first commit was a major overhaul of Collect. I guess it could wait until the tree-sitter extension is merged, so we do not have two overhauls going on at the same time. |
Member
|
Please add [WIP] in the PR title or change to draft PR when not planning to merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
优化合集
效果 相关讨论
还有一些不确定要不要 push
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: