Skip to content

Conversation

@Okabe-Junya
Copy link
Collaborator

@Okabe-Junya Okabe-Junya commented Dec 15, 2025

Describe your changes

Remove legacy files from Hugo site migration that are not used in this project (cf. #229)

  • Dockerfile: Unused, just a template from Docsy theme
  • docker-compose.yaml: Unused, too outdated configuration
  • deploy.sh: S3 deploy script for different project (bep.is), glossary project uses Netlify

Related issue number or link (ex: resolves #issue-number)

N/A

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@Okabe-Junya Okabe-Junya self-assigned this Dec 15, 2025
@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 28e5aaa
🔍 Latest deploy log https://app.netlify.com/projects/cncfglossary/deploys/69404b41ef67e900081308bb
😎 Deploy Preview https://deploy-preview-3604--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Junya Okabe <junya.okabe.ig@gmail.com>
@Okabe-Junya Okabe-Junya force-pushed the cleanup/remove-unused-docker-files branch from 1c2bda3 to 28e5aaa Compare December 15, 2025 17:54
@Okabe-Junya Okabe-Junya marked this pull request as ready for review December 15, 2025 17:54
@Okabe-Junya Okabe-Junya added the maintainers Use this label if PR requires maintainers to take action label Dec 15, 2025
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with removing these files.

Separately from this PR, I think it would be nice to provide a local build and test environment as a container manifest (like Dockerfile), as it would free many people from the hassle of installing npm and Hugo and managing versions.

To achieve this, we can refer K8s docs repo:

@Okabe-Junya
Copy link
Collaborator Author

I agree with removing these files.

Separately from this PR, I think it would be nice to provide a local build and test environment as a container manifest (like Dockerfile), as it would free many people from the hassle of installing npm and Hugo and managing versions.

To achieve this, we can refer K8s docs repo:

Thanks, yes, I'll work on this in another PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainers Use this label if PR requires maintainers to take action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants