test(examples-plugins): do not use memfs in integration tests, intended for unit tests only#1127
Merged
matejchalk merged 1 commit intomainfrom Oct 15, 2025
Merged
Conversation
…ed for unit tests only
|
View your CI Pipeline Execution ↗ for commit de43f5f
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit de43f5f
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 9706fb1 with previous commit d5ca550. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 2 groups regressed, 👍 2 audits improved, 👎 3 audits regressed, 16 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
589 other audits are unchanged. |
hanna-skryl
approved these changes
Oct 14, 2025
vmasek
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some integration tests in example plugins were using
memfsmocks. This breaks our testing strategy - only unit tests should be using a mock file system, integration and E2E tests should use the real file system intmp.