Skip to content

Env. for Http Server Host #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raphael-goetz merged 2 commits into from
Dec 4, 2025
Merged

Env. for Http Server Host #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd81a55
feat: added http server host env variable
raphael-goetz Dec 4, 2025
ec69a30
ref: cargo clippy & fmt
raphael-goetz Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion adapter/rest/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,17 @@ impl IdentifiableFlow for RequestRoute {
#[async_trait]
impl ServerTrait<HttpServerConfig> for HttpServer {
async fn init(&mut self, ctx: &ServerContext<HttpServerConfig>) -> anyhow::Result<()> {
self.http_server = Some(Server::new(ctx.server_config.port));
log::info!("Initializing http server");
self.http_server = Some(Server::new(
ctx.server_config.host.clone(),
ctx.server_config.port,
));
Ok(())
}

async fn run(&mut self, ctx: &ServerContext<HttpServerConfig>) -> anyhow::Result<()> {
if let Some(server) = &mut self.http_server {
log::info!("Running http server");
server.register_async_closure({
let store = Arc::clone(&ctx.adapter_store);
move |request: HttpRequest| {
Expand Down Expand Up @@ -163,12 +168,14 @@ async fn execute_flow(
#[derive(Clone)]
struct HttpServerConfig {
port: u16,
host: String,
}

impl LoadConfig for HttpServerConfig {
fn load() -> Self {
Self {
port: env_with_default("HTTP_SERVER_PORT", 8082),
host: env_with_default("HTTP_SERVER_HOST", String::from("0.0.0.0")),
}
}
}
8 changes: 5 additions & 3 deletions crates/http/src/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,16 @@ where
}

pub struct Server {
host: String,
port: u16,
handlers: Arc<Vec<Box<dyn AsyncHandler>>>,
shutdown_tx: Option<tokio::sync::broadcast::Sender<()>>,
}

impl Server {
pub fn new(port: u16) -> Self {
pub fn new(host: String, port: u16) -> Self {
Server {
host,
port,
handlers: Arc::new(Vec::new()),
shutdown_tx: None,
Expand Down Expand Up @@ -74,8 +76,8 @@ impl Server {
}

async fn run_server(&self, shutdown_rx: &mut tokio::sync::broadcast::Receiver<()>) {
let url = format!("127.0.0.1:{}", self.port);

let url = format!("{}:{}", self.host, self.port);
log::info!("Starting http server on {}", &url);
let listener = match TcpListener::bind(&url) {
Ok(listener) => {
listener
Expand Down