Skip to content

Implement disabled reason for flow #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Knerio wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement disabled reason for flow #782

Knerio wants to merge 2 commits into from

Conversation

@Knerio
Copy link
Member

@Knerio Knerio commented Dec 17, 2025

close #781

@Knerio Knerio requested a review from Taucher2003 December 17, 2025 13:59
@Knerio Knerio self-assigned this Dec 17, 2025
@Knerio Knerio changed the base branch from main to 777-add-slug-for-projects December 17, 2025 14:00
@github-actions
Copy link

github-actions bot commented Dec 17, 2025 •
edited
Loading

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2220856753

Status: Passed
Duration: 5 minutes

Job summaries

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12476009009/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2220856753/test_report
Finished in 22.79 seconds (files took 10.74 seconds to load)
1306 examples, 0 failures
Line Coverage: 91.58% (4439 / 4847)
[TEST PROF INFO] Time spent in factories: 00:12.452 (43.18% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12476009007/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2220856753/test_report
Finished in 20.8 seconds (files took 11.18 seconds to load)
1259 examples, 0 failures
Line Coverage: 91.03% (4271 / 4692)
[TEST PROF INFO] Time spent in factories: 00:11.384 (41.95% of total time)

rubocop

724 files inspected, no offenses detected

@Knerio Knerio force-pushed the 781-implement-disabled_reason-for-flow branch 3 times, most recently from bcd4797 to 2524e50 Compare December 17, 2025 20:07
@Knerio Knerio force-pushed the 781-implement-disabled_reason-for-flow branch from 2524e50 to bead536 Compare December 17, 2025 20:18
@Taucher2003 Taucher2003 changed the title 781 implement disabled reason for flow Implement disabled reason for flow Dec 18, 2025
Base automatically changed from 777-add-slug-for-projects to main December 21, 2025 19:35
Taucher2003
Taucher2003 reviewed Dec 28, 2025
View reviewed changes
app/graphql/types/input/flow_input_type.rb
argument :type, Types::GlobalIdType[::FlowType], required: true,
description: 'The identifier of the flow type'

argument :disabled_reason, String,
Copy link
Member

@Taucher2003 Taucher2003 Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't have exposed this to the user because the reason would for example be used when a flow gets disabled because the namespace reached its execution quota and we don't want the user to re-enable the flow themself by just removing the disabled_reason.

Copy link
Member Author

@Knerio Knerio Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought thats a user string to disable the flow, maybe we should add translations there for different messages, like quota and other stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Taucher2003 Taucher2003 Taucher2003 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Knerio Knerio

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement disabled_reason for flow

3 participants

@Knerio @Taucher2003