Skip to content

Implement updating flow type settings #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Taucher2003 merged 1 commit into from
Dec 27, 2025
Merged

Implement updating flow type settings #810

Taucher2003 merged 1 commit into from
Dec 27, 2025
+55 −0

Conversation

@Knerio
Copy link
Member

@Knerio Knerio commented Dec 25, 2025

close #794

@Knerio Knerio requested a review from Taucher2003 December 25, 2025 10:30
@Knerio Knerio self-assigned this Dec 25, 2025
@github-actions
Copy link

github-actions bot commented Dec 25, 2025 •
edited
Loading

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2232656120

Status: Passed
Duration: 5 minutes

Job summaries

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12542545416/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2232656120/test_report
Finished in 21.83 seconds (files took 10.5 seconds to load)
1306 examples, 0 failures
Line Coverage: 91.58% (4457 / 4867)
[TEST PROF INFO] Time spent in factories: 00:11.951 (43.21% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12542545414/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2232656120/test_report
Finished in 22.79 seconds (files took 13.94 seconds to load)
1259 examples, 0 failures
Line Coverage: 91.02% (4289 / 4712)
[TEST PROF INFO] Time spent in factories: 00:12.190 (39.32% of total time)

rubocop

725 files inspected, no offenses detected

@Knerio Knerio force-pushed the 794-flowtypeupdateservice-does-not-save-flowsettings branch from 34acb59 to 8741350 Compare December 25, 2025 15:06
Taucher2003
Taucher2003 approved these changes Dec 27, 2025
View reviewed changes
@Taucher2003 Taucher2003 merged commit d511219 into main Dec 27, 2025
1 check passed
@Taucher2003 Taucher2003 deleted the 794-flowtypeupdateservice-does-not-save-flowsettings branch December 27, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Taucher2003 Taucher2003 Taucher2003 approved these changes

Assignees

@Knerio Knerio

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FlowType::UpdateService does not save FlowSettings

3 participants

@Knerio @Taucher2003